Skip to content

Conversation

imlucas
Copy link
Contributor

@imlucas imlucas commented Oct 25, 2016

From Oct 2016 Skunkworks

@rueckstiess
Copy link
Contributor

rueckstiess commented Oct 26, 2016

@imlucas, love love love the code cleanup!

  • Small but important typo: src/app/home/index.less line 1 mu.t have ; at the end, otherwise I wasn't able to even start Compass.
    at /Users/tr/code/integrations/compass/node_modules/graceful-fs/graceful-fs.js:78:16 at tryToString (fs.js:455:3) at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:442:12) type: 'Syntax', message: 'missing semi-colon or unrecognised media features on import', filename: '/Users/tr/code/integrations/compass/src/app/home/index.less', index: 0, line: 1,

Otherwise LGTM.

(a previous version of this PR had some odd behavior with the windows, but it was a problem on my end).

@@ -1,3 +1,5 @@
@import "./collection-stats/index.less"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must have a ; at the end or it won't build.

Otherwise `npm start` doesn't work.
@imlucas imlucas merged commit c88096d into master Oct 26, 2016
@imlucas imlucas deleted the cleanup-dead-code branch October 26, 2016 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants