-
Notifications
You must be signed in to change notification settings - Fork 234
Cleanup dead code #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Cleanup dead code #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
Was long ago ported to react. @see ./src/internal-packages/explain
Were ported to react some time ago. See ./src/internal-packages/schema
makes migration to a compass package easier
Where they’re actually used.
5908345
to
f9f1755
Compare
@imlucas, love love love the code cleanup!
Otherwise LGTM. (a previous version of this PR had some odd behavior with the windows, but it was a problem on my end). |
rueckstiess
reviewed
Oct 26, 2016
src/app/home/index.less
Outdated
@@ -1,3 +1,5 @@ | |||
@import "./collection-stats/index.less" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must have a ;
at the end or it won't build.
Otherwise `npm start` doesn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Oct 2016 Skunkworks