Compass-314: First style pass for read-only banner #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoved rounded borders of banner
|
How does this fit in with #617 ? I think it was also be nice to display the readonly indicator next to the collection name at the top as well. |
|
Hi Sean, I thought I make all the "read-only" banners consistent with the other warnings and went with the yellow from the heroku prototype. See #617. Maybe that was not the intention? I don't really care if they are blue or yellow, as long as they are consistent. We could still add the read-only pill in the banner regardless what color it is. Sorry if my changes conflict with this ticket here. Let me know how you'd like to proceed. |
|
Hi @rueckstiess - I'll revise to stay consistent with your yellow banners from #617! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @fredtruman
I added the same CSS lines in the three separate .less files for each tab. I think its a better idea to just place them in one file and use the same classnames for each banner. What do you think?