COMPASS-292 explain view zero state #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 22, 2016 17:56
Note: Validation had its own StatusRow component. I renamed that to ValidationStatusRow, including styles. Eventually, the two status rows should be unified if possible.
rueckstiess
force-pushed
the
COMPASS-292-explain-zero-state
branch
from
8a287a6 to
8cc48a8
Compare
|
LGTM |
rueckstiess
added a commit
that referenced
this pull request
Nov 22, 2016
* add App.StatusRow component (shared component) and styles. * remove explain's own StatusRow and use App.StatusRow * replace index notice with App.StatusRow for consistency. * remove validation notice and replace with App.StatusRow Note: Validation had its own StatusRow component. I renamed that to ValidationStatusRow, including styles. Eventually, the two status rows should be unified if possible. # Conflicts: # src/internal-packages/explain/lib/components/compass-explain.jsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included in this change:
zero state on explain view (yellow warning box, as shown in prototype)
warning about read-only views changed to same style for explain, indexes, validation