Skip to content

COMPASS-382 and COMPASS-383 - Improve RTSS error handling #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2016
Merged

COMPASS-382 and COMPASS-383 - Improve RTSS error handling #638

merged 2 commits into from
Nov 30, 2016

Conversation

aherlihy
Copy link
Contributor

@aherlihy aherlihy commented Nov 28, 2016 •
edited
Loading

@aherlihy aherlihy mentioned this pull request Nov 28, 2016
Merged
@durran
Copy link
Member

durran commented Nov 29, 2016

Needs rebase and can now point to 0.3.0 of mongodb-errors.

durran
durran reviewed Nov 29, 2016
View reviewed changes
package.json Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could actually bump the data-service to ^2.2.0 and it will pick this change up. That way mongodb-js-errors wouldn't need to be included here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@durran durran merged commit ffff0d9 into mongodb-js:master Nov 30, 2016
@durran durran deleted the 382-dev branch November 30, 2016 16:28
pzrq pushed a commit that referenced this pull request Dec 9, 2016
@aherlihy @pzrq
COMPASS-382 and COMPASS-383 - Improve RTSS error handling (#638)
56189a4 
* COMPASS-382 and COMPASS-383 - Improve RTSS error handling

* Update mongodb-data-service dependency to 2.2.0
durran pushed a commit that referenced this pull request Dec 20, 2016
@pzrq @durran
Explicitly backport COMPASS-317 COMPASS-382 COMPASS-383 COMPASS-503 (#…
1dfd99d 
…667)

* COMPASS-317 ⬆️ mongodb-data-service@2.1.7 (#630)

* COMPASS-382 and COMPASS-383 - Improve RTSS error handling (#638)

* COMPASS-382 and COMPASS-383 - Improve RTSS error handling

* Update mongodb-data-service dependency to 2.2.0

* COMPASS 503 ⬆️ mongodb-connection-model@6.3.4 && mongodb-data-service@2.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran left review comments

Assignees
No one assigned
Labels
backport:maybe ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aherlihy @durran @imlucas