Explicitly backport COMPASS-317 COMPASS-382 COMPASS-383 COMPASS-503 #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* COMPASS-382 and COMPASS-383 - Improve RTSS error handling * Update mongodb-data-service dependency to 2.2.0
|
Might be useful if we do a 1.5.1 release (COMPASS-408), otherwise is of no value. |
|
I think we're aiming to do a 1.5.1 tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@imlucas Please review as I think you know the most about how all these changes are likely to interact with each other. I have confirmed COMPASS-503 (SSH Tunnel + Auth) works on this branch after an
npm run clean; npm install; npm startbut am not so sure how to test the RTSS errors changes.The RTSS changes are part of this branch due to cherry-pick merge conflicts that would otherwise require publishing a new data-service version without the RTSS changes.
Basically if I understand node-semver:
Would just like to confirm that's all kosher before merging to 1.5-releases, whether via this PR or via fast-forward merge along the branch as we tend to prefer.