Skip to content

Conversation

kraenhansen
Copy link
Contributor

Description

This is an attempt to make the smoke / install tests less brittle by asserting the existence of the Compass executable instead of actually running it.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kraenhansen kraenhansen self-assigned this May 24, 2025
@kraenhansen kraenhansen added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label May 24, 2025
@kraenhansen kraenhansen marked this pull request as ready for review May 25, 2025 11:53
@kraenhansen
Copy link
Contributor Author

kraenhansen commented May 25, 2025

I've restarted the task 5 times and it's passed every time 🎉

@kraenhansen kraenhansen requested a review from lerouxb May 25, 2025 13:26
@lerouxb
Copy link
Contributor

lerouxb commented May 25, 2025

yay! We could also do this the same for the other platforms.

@gribnoysup gribnoysup changed the title chore(smoke-tests): use fs.existsSync instead of running compass to verify installs chore(smoke-tests): use fs.existsSync instead of running compass to verify installs COMPASS-9406 May 26, 2025
@gribnoysup
Copy link
Collaborator

@kraenhansen hope you don't mind, I'll merge it to see if the cloud bot will be satisfied by this fix 😄

@gribnoysup gribnoysup merged commit 4efa62e into main May 26, 2025
156 of 157 checks passed
@gribnoysup gribnoysup deleted the kh/install-tests/windows-without-preflights branch May 26, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants