Skip to content

chore(smoke-tests): use fs.existsSync instead of running compass to verify installs COMPASS-9406 #6963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

chore(smoke-tests): use fs.existsSync instead of running compass to verify installs COMPASS-9406 #6963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/compass-smoke-tests/src/installers/windows-msi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import assert from 'node:assert/strict';
import path from 'node:path';
import fs from 'node:fs';

import createDebug from 'debug';

import type { InstalledAppInfo, InstallablePackage } from './types';
Expand Down Expand Up @@ -46,9 +48,8 @@ export function installWindowsMSI({
'/passive',
`APPLICATIONROOTDIRECTORY=${installDirectory}`,
]);

// Check that the executable will run without being quarantined or similar
execute(appPath, ['--version']);
// Check if the app executable exists after installing
assert(fs.existsSync(appPath), `Expected ${appPath} to exist`);

return {
appName,
Expand Down
7 changes: 6 additions & 1 deletion packages/compass-smoke-tests/src/installers/windows-setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,12 @@ export function installWindowsSetup({
'Expected an entry in the registry with the install location'
);
const appExecutablePath = path.resolve(appPath, `${appName}.exe`);
execute(appExecutablePath, ['--version']);

// Check if the app executable exists after installing
assert(
fs.existsSync(appExecutablePath),
`Expected ${appExecutablePath} to exist`
);

return {
appName,
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-smoke-tests/src/installers/windows-zip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import assert from 'node:assert/strict';
import path from 'node:path';
import fs from 'node:fs';

import type { InstalledAppInfo, InstallablePackage } from './types';
import { execute } from '../execute';
Expand All @@ -16,8 +17,8 @@ export function installWindowsZIP({

execute('unzip', [filepath, '-d', sandboxPath]);

// see if the executable will run without being quarantined or similar
execute(appPath, ['--version']);
// Check if the app executable exists after unzipping
assert(fs.existsSync(appPath), `Expected ${appPath} to exist`);

return {
appName,
Expand Down
Loading