Skip to content

Conversation

lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Sep 4, 2025

COMPASS-9787

  • Clicking either Review or Debug for me now closes the toast. This is because if you click Review it opens a modal and modals in combination with toasts are just broken.
  • Added word-break: break-word so that crazy long "words" in error messages don't break the toast's layout.

before:
Screenshot 2025-09-04 at 08 52 02

after:
Screenshot 2025-09-04 at 08 52 17

@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 07:55
@lerouxb lerouxb requested a review from a team as a code owner September 4, 2025 07:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues with connection error toast notifications in Compass by ensuring both action buttons close the toast when clicked and improving text layout for long error messages.

  • Removes conditional logic for closing toast on Review button click
  • Adds toast closing behavior to Debug button click
  • Applies CSS word-break styling to prevent layout issues with long error messages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the fix label Sep 4, 2025
@lerouxb lerouxb added the feature flagged PRs labeled with this label will not be included in the release notes of the next release label Sep 4, 2025
@lerouxb lerouxb merged commit 4e96953 into main Sep 4, 2025
56 of 60 checks passed
@lerouxb lerouxb deleted the connection-toast-fixes branch September 4, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature flagged PRs labeled with this label will not be included in the release notes of the next release fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants