Skip to content

fix(compass-connections): connection toast fixes COMPASS-9787 #7278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

fix(compass-connections): connection toast fixes COMPASS-9787 #7278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24819ee
always close the connection error toast when clicking an action
lerouxb Sep 4, 2025
af1fe1f
break words so crazy errors don't break the layout
lerouxb Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/compass-connections/src/components/connection-status-notifications.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ const connectionErrorActionsStyles = css({
const connectionErrorStyles = css({
display: 'flex',
flexDirection: 'column',
wordBreak: 'break-word',
});

const connectionErrorTitleStyles = css({
Expand Down Expand Up @@ -201,16 +202,15 @@ const openConnectionFailedToast = ({
onReview={
onReviewClick
? () => {
if (!onDebugClick) {
// don't close the toast if there are two actions so that the user
// can still use the other one
closeToast(`connection-status--${failedToastId}`);
}
closeToast(`connection-status--${failedToastId}`);
onReviewClick();
}
: undefined
}
onDebug={onDebugClick}
onDebug={() => {
closeToast(`connection-status--${failedToastId}`);
onDebugClick?.();
}}
/>
),
variant: 'warning',
Expand Down
Loading