Skip to content

Conversation

lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Sep 11, 2025

  • added optional warning prop support to showConfirmation().
  • used that in crud-store where we show the confirmation

One thing missing is I didn't add the bolding because crud-store.ts is a) not .tsx, b) kinda ancient and still a class. So no quick/easy way of putting jsx (for the bold tags) in there that I can think of.

Maybe something for the project where we fix up compass-crud?

Screenshot 2025-09-11 at 12 30 54

@lerouxb lerouxb requested a review from Anemy September 11, 2025 11:31
@lerouxb lerouxb requested a review from a team as a code owner September 11, 2025 11:31
@Copilot Copilot AI review requested due to automatic review settings September 11, 2025 11:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds warning banner support to the delete confirmation modal by enhancing the showConfirmation() function with an optional warning prop and using it in the CRUD store to display a warning about document visibility during bulk delete operations.

  • Added optional warning prop to the showConfirmation() function interface
  • Implemented warning banner rendering using LeafyGreen Banner component in confirmation modals
  • Added a specific warning message in crud-store for bulk delete operations about document visibility

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/compass-crud/src/stores/crud-store.ts Added warning message to bulk delete confirmation about document visibility and real-time updates
packages/compass-components/src/hooks/use-confirmation.tsx Enhanced showConfirmation hook to support optional warning prop and render warning banner

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@addaleax addaleax changed the title add warning banner to the delete confirmation modal fix(compass-crud): add warning banner to the delete confirmation modal Sep 11, 2025
@github-actions github-actions bot added the fix label Sep 11, 2025
@lerouxb lerouxb changed the title fix(compass-crud): add warning banner to the delete confirmation modal fix(compass-crud): add warning banner to the delete confirmation modal COMPASS-9839 Sep 11, 2025
@lerouxb lerouxb merged commit 5777542 into main Sep 11, 2025
56 of 61 checks passed
@lerouxb lerouxb deleted the delete-confirm-banner branch September 11, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants