Skip to content

fix(compass-crud): add warning banner to the delete confirmation modal COMPASS-9839 #7311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

fix(compass-crud): add warning banner to the delete confirmation modal COMPASS-9839 #7311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/compass-components/src/hooks/use-confirmation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import ConfirmationModal from '../components/modals/confirmation-modal';
import { css } from '@leafygreen-ui/emotion';
import type { ButtonProps } from '@leafygreen-ui/button';
import FormFieldContainer from '../components/form-field-container';
import { TextInput } from '../components/leafygreen';
import { Banner, TextInput } from '../components/leafygreen';
import { spacing } from '@leafygreen-ui/tokens';

export { ConfirmationModalVariant };

Expand All @@ -24,6 +25,7 @@ type ConfirmationProperties = Partial<
hideConfirmButton?: boolean;
hideCancelButton?: boolean;
description?: React.ReactNode;
warning?: React.ReactNode;
signal?: AbortSignal;
'data-testid'?: string;
};
Expand Down Expand Up @@ -93,6 +95,7 @@ const confirmationModalState = new GlobalConfirmationModalState();
*
* @param props ConfirmationModal rendering properties
*/

export const showConfirmation = confirmationModalState.showConfirmation.bind(
confirmationModalState
);
Expand All @@ -101,6 +104,10 @@ const hideButtonStyles = css({
display: 'none !important',
});

const warningBannerStyles = css({
marginTop: spacing[400],
});

const ConfirmationModalStateHandler: React.FunctionComponent = ({
children,
}) => {
Expand Down Expand Up @@ -191,6 +198,11 @@ const ConfirmationModalStateHandler: React.FunctionComponent = ({
requiredInputText={confirmationProps.requiredInputText ?? undefined}
>
{confirmationProps.description}
{confirmationProps.warning && (
<Banner variant="warning" className={warningBannerStyles}>
{confirmationProps.warning}
</Banner>
)}
</ConfirmationModal>
</>
);
Expand Down
2 changes: 2 additions & 0 deletions packages/compass-crud/src/stores/crud-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1955,6 +1955,8 @@ class CrudStoreImpl
description: `This action can not be undone. This will permanently delete ${
affected ?? 'an unknown number of'
} document${affected !== 1 ? 's' : ''}.`,
warning:
'The document list and count may not always reflect the latest updates in real time. This action will apply to all relevant documents, including those not currently visible, so please ensure they are handled safely.',
variant: 'danger',
});

Expand Down
Loading