-
Notifications
You must be signed in to change notification settings - Fork 234
Compass-616: Collapsible Sidebar and Flexbox Layout Support #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ontent on column-container
return ( | ||
<div className="index-container header-margin"> | ||
<div className="index-container"> | ||
{/* NOT SURE if we need to wrap the controls-container in a readonly conditional as well. */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was tricky, but I needed to break the render up so that the "controls-container" is a sibling to the "column-container", not a child.
Not sure who has the most context for this index view? @KeyboardTsundoku
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should know enough to help with this :)
but it seems to be working fine
{this.CollectionStore.isReadonly() ? this.renderReadonly() : this.renderComponent()} | ||
</div> | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this kosher @KeyboardTsundoku ? Needed to move the controls out of the "column-container" and wrap them as a sibling in "controls-container"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fine, i'll do some testing with read-only views and see if there are any issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…ontent on column-container
This is insanely awesome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style-wise LGTM
but functional tests are broken and switching tabs at instance level is not working as @samweaver pointed out.
I'll have a look at the functional tests later + other changes 👍
Ah, that's funny on RTSS view 🤔 |
I've made a separate PR for rebasing this branch with master: #749 it was getting a bit gnarly |
A couple of comments after first using this new version:
Otherwise it's fantastic and I'm glad we finally use flexbox everywhere and fixed the issue with variable heights of the control-containers. Much cleaner and more flexible this way. One can just add another "status/action bar" component without change style. |
Good points 👍 Will move comments to https://jira.mongodb.org/browse/COMPASS-683 and address in coming sprint. |
These changes are intended to do three things:
Affects basically every view in Compass.
Expanded sidebar:

Collapsed sidebar:

Example here of flexbox support for content view in the documents view with variable height "controls":

