-
Notifications
You must be signed in to change notification settings - Fork 234
COMPASS 685: fix flexbox redesign #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c95cf6b
to
85fb32f
Compare
66b8306
to
9f74ce9
Compare
8d6ad39
to
5cb294d
Compare
@fredtruman the functional tests were failing because of this flex-shrink property here: https://github.com/10gen/compass/pull/749/files#diff-ccce7586ade2f8a7a5d8e4f27d02c1c6R28 To give some context, the tests were failing because the delete buttons on Databases/Collections table were not visible on Travis (I'm assuming because it resizes to a smaller view?). @rueckstiess made the discovery that flex-shrink was affecting the minimum width and after this change everything still shows after resize takes place. Also I'm closing the 616 branch to avoid confusion, everything you've done is already included here and rebased to master. |
5cb294d
to
3b6b386
Compare
|
||
/** | ||
* toggle the sidebar | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I've added this method here to toggle the sidebar in functional tests but it's not being used at the moment. Can remove if it's too soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave it in, good to have for the future.
Looks good, passes tests, are we ready to merge this, @fredtruman? Or did you want to continue evolving it? I think it's not taking anything away, so we could merge it to master now and you could continue on COMPASS-683 whenever you get a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh man - I'm so sorry that it was such a silly issue causing the tests to break.
I owe you a 🍺
LGTM to merge. I'll continue on style tweaks with https://jira.mongodb.org/browse/COMPASS-683 when this is in.
Thanks!
Thanks all, merging 👍 Looks like everyone's in agreement, merging so I can resolve any possible conflicts that may arise with #745. |
This pr is a squash and merge of COMPASS-616
and includes fix of lint issues that were failing travis tests