Skip to content

Conversation

satyasinha
Copy link

@satyasinha satyasinha commented Jan 18, 2017

This pr is a squash and merge of COMPASS-616
and includes fix of lint issues that were failing travis tests

@satyasinha satyasinha force-pushed the COMPASS-685-fix-flexbox-redesign branch 3 times, most recently from c95cf6b to 85fb32f Compare January 18, 2017 05:37
@satyasinha satyasinha force-pushed the COMPASS-685-fix-flexbox-redesign branch 5 times, most recently from 66b8306 to 9f74ce9 Compare January 19, 2017 06:22
@satyasinha satyasinha force-pushed the COMPASS-685-fix-flexbox-redesign branch 5 times, most recently from 8d6ad39 to 5cb294d Compare January 20, 2017 04:17
@satyasinha
Copy link
Author

@fredtruman the functional tests were failing because of this flex-shrink property here: https://github.com/10gen/compass/pull/749/files#diff-ccce7586ade2f8a7a5d8e4f27d02c1c6R28
it used to be set to 0. Do you think this is ok? It affects how resizing to a smaller view renders all the icons.

To give some context, the tests were failing because the delete buttons on Databases/Collections table were not visible on Travis (I'm assuming because it resizes to a smaller view?). @rueckstiess made the discovery that flex-shrink was affecting the minimum width and after this change everything still shows after resize takes place.

Also I'm closing the 616 branch to avoid confusion, everything you've done is already included here and rebased to master.

@satyasinha satyasinha force-pushed the COMPASS-685-fix-flexbox-redesign branch from 5cb294d to 3b6b386 Compare January 20, 2017 05:02

/**
* toggle the sidebar
*/
Copy link
Author

@satyasinha satyasinha Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I've added this method here to toggle the sidebar in functional tests but it's not being used at the moment. Can remove if it's too soon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave it in, good to have for the future.

@rueckstiess
Copy link
Contributor

Looks good, passes tests, are we ready to merge this, @fredtruman? Or did you want to continue evolving it?

I think it's not taking anything away, so we could merge it to master now and you could continue on COMPASS-683 whenever you get a chance.

Copy link
Contributor

@fredtruman fredtruman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man - I'm so sorry that it was such a silly issue causing the tests to break.

I owe you a 🍺

LGTM to merge. I'll continue on style tweaks with https://jira.mongodb.org/browse/COMPASS-683 when this is in.

Thanks!

@pzrq
Copy link
Contributor

pzrq commented Jan 21, 2017

Thanks all, merging 👍

Looks like everyone's in agreement, merging so I can resolve any possible conflicts that may arise with #745.

@pzrq pzrq merged commit 3fa16a5 into master Jan 21, 2017
@pzrq pzrq deleted the COMPASS-685-fix-flexbox-redesign branch January 21, 2017 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants