COMPASS-703 extract index field names from arrays of sub-docs #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherlihy
approved these changes
Mar 1, 2017
There was a problem hiding this comment.
LGTM, except the travis failure which looks like it may be unrelated (same as #807 (comment))?
Going to trigger it again and see what happens.
durran
pushed a commit
that referenced
this pull request
Mar 1, 2017
imlucas
pushed a commit
that referenced
this pull request
Mar 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master was extracting nested field names, but not out of arrays of sub-documents. This change fixes it and adds a unit test.
With a collection of these docs:
The field dropdown in the "create index" modal now shows nested fields from arrays of sub-documents, e.g.
reviews.rating.