This repository was archived by the owner on May 17, 2021. It is now read-only.
feat: Add isConnected method to dataService to allow easy access to connection status of the internal MongoClient COMPASS-4741 #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection status of the internal MongoClient
mcasimir
approved these changes
Mar 30, 2021
mcasimir
reviewed
Mar 30, 2021
| service.disconnect(done); | ||
| }); | ||
|
|
||
| describe('#isConnected', () => { |
There was a problem hiding this comment.
what about the other way around?
There was a problem hiding this comment.
Got a little lazy, added in 2eb3803
gribnoysup
deleted the
compass-4741-expose-is-connected-status-on-data-service
branch
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to expose this information so that we can check if client is connected before using any methods on it in compass plugins