feat(NODE-7043): add support for custom error wrapping functions #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-7043
branch
from
aacadcc to
4242180
Compare
5 tasks
durran
added
the
Primary Review
durran
reviewed
Sep 30, 2025
| readonly kmsProvider: string; | ||
| readonly endpoint: string; | ||
| readonly message: Buffer; | ||
| addMongoOperationResponse(response: Uint8Array): void { |
There was a problem hiding this comment.
Just a note from our conversations, we discussed potentially drying this up by passing a bound function to the provided error wrapper and the try catch happening there, but were worried about the potential performance implications having to bind this outside of module load time.
durran
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR adds support for a custom error-wrapping function in the bindings. The function is used to wrap any error that is thrown from the C++ bindings. This is accomplished by subclassing the classes exported from our C++ bindings with wrappers that try-catch any errors thrown from C++.
This PR has a corresponding driver PR that uses the error wrapper to wrap errors in a MongoCryptError.
Patch against driver: https://spruce.mongodb.com/version/68daedb19fc9d800072eb762/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
What is the motivation for this change?
Release Highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript