DO NOT MERGE: feat(NODE-7043, NODE-7217)!: wrap errors from mongodb-client-encryption in MongoCryptError instances #4694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-7043-error-wrapper
branch
from
c798920 to
263beb0
Compare
5 tasks
baileympearson
changed the title
baileympearson
changed the title
5 tasks
|
superseded by #4705 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR is a small feature branch containing the driver changes corresponding to breaking mongodb-client-encryption changes. It contains:
enableMultipleCollInfo(it now defaults to 'enabled')Warning
Do not merge this PR until all mongodb-client-encryption changes are completed, an alpha has been released, and this PR is updated to use the alpha.
Notes for Reviewers
The changes in mongodb-js/mongodb-client-encryption#102 must be released before CI passes fully. The custom dependency tests use the changes from my other PR and should be passing.
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript