chore: turn some javascript and typescript lint rules back into errors MONGOSH-1508

configs/eslint-config-mongosh/index.js

@@ -3,8 +3,7 @@
 const shared = require('@mongodb-js/eslint-config-devtools');
 const common = require('@mongodb-js/eslint-config-devtools/common');
 
-// TODO(MONGOSH-1508) we need to turn these back into errors (and fix them) or ticket them
-const tempRules = {
+const extraJSRules = {
   'jsx-a11y/no-autofocus': 1,
   'jsx-a11y/click-events-have-key-events': 1,
   'jsx-a11y/no-static-element-interactions': 1,
@@ -14,28 +13,30 @@ const tempRules = {
   'mocha/max-top-level-suites': 1,
   'mocha/no-sibling-hooks': 1,
 
+  // this would disallow our locale files' filenames like de_DE.ts
   'filename-rules/match': 1,
 
-  'no-useless-escape': 1,
-  'no-undef': 1,
-  'no-prototype-builtins': 1,
-  'no-async-promise-executor': 1,
+  // TODO(MONGOSH-1580): re-enable this rule
   'no-case-declarations': 1,
 };
 
-// TODO(MONGOSH-1508) we need to turn these back into errors (and fix them) or ticket them
-const tempTypescriptRules = {
+const extraTypescriptRules = {
+  // this rule causes many false positives, so we leave it to just warn
   '@typescript-eslint/no-unnecessary-type-assertion': 1,
+
+  // TODO(MONGOSH-1581): re-enable this rule
   '@typescript-eslint/restrict-plus-operands': 1,
+  // TODO(MONGOSH-1582): re-enable this rule
   '@typescript-eslint/no-var-requires': 1,
+  // TODO(MONGOSH-1583): re-enable this rule
   '@typescript-eslint/restrict-template-expressions': 1,
+  // TODO(MONGOSH-1584): re-enable this rule
   '@typescript-eslint/no-empty-function': 1,
+  // TODO(MONGOSH-1585): re-enable this rule
   '@typescript-eslint/no-misused-promises': 1,
-  '@typescript-eslint/consistent-type-imports': 1,
+  // TODO(MONGOSH-1586): re-enable this rule
   '@typescript-eslint/unbound-method': 1,
-  '@typescript-eslint/no-implied-eval': 1,
-  '@typescript-eslint/no-unused-vars': 1,
-  '@typescript-eslint/prefer-regexp-exec': 1,
+  // TODO(MONGOSH-1587): re-enable this rule
   '@typescript-eslint/ban-types': 1,
 };
 
@@ -52,46 +53,46 @@ module.exports = {
       ...common.jsOverrides,
       rules: {
         ...common.jsRules,
-        ...tempRules,
+        ...extraJSRules,
       },
     },
     {
       ...common.jsxOverrides,
       rules: {
         ...common.jsxRules,
-        ...tempRules,
+        ...extraJSRules,
       },
     },
     {
       ...common.tsOverrides,
       rules: {
         ...common.tsRules,
-        ...tempRules,
-        ...tempTypescriptRules,
+        ...extraJSRules,
+        ...extraTypescriptRules,
       },
     },
     {
       ...common.tsxOverrides,
       rules: {
         ...common.tsxRules,
-        ...tempRules,
-        ...tempTypescriptRules,
+        ...extraJSRules,
+        ...extraTypescriptRules,
       },
     },
     {
       ...common.testOverrides,
       rules: {
         ...common.testRules,
-        ...tempRules,
+        ...extraJSRules,
       },
     },
     {
       ...common.testOverrides,
       files: ['**/*.spec.ts', '**/*.spec.tsx', '**/*.test.tsx', '**/*.test.ts'],
       rules: {
         ...common.testRules,
-        ...tempRules,
-        ...tempTypescriptRules,
+        ...extraJSRules,
+        ...extraTypescriptRules,
       },
     },
   ],

packages/build/src/download-center/config.spec.ts

@@ -10,7 +10,8 @@ import {
   createAndPublishDownloadCenterConfig,
   createJsonFeedEntry,
 } from './config';
-import { Server as HTTPServer, createServer as createHTTPServer } from 'http';
+import { createServer as createHTTPServer } from 'http';
+import type { Server as HTTPServer } from 'http';
 import { once } from 'events';
 import path from 'path';
 import fetch from 'node-fetch';

packages/build/src/homebrew/generate-formula.spec.ts

@@ -29,8 +29,8 @@ class Mongosh < Formula
   end
 
   test do
-    assert_match "ECONNREFUSED 0.0.0.0:1", shell_output("#{bin}/mongosh \"mongodb://0.0.0.0:1\" 2>&1", 1)
-    assert_match "#ok#", shell_output("#{bin}/mongosh --nodb --eval \"print('#ok#')\"")
+    assert_match "ECONNREFUSED 0.0.0.0:1", shell_output("#{bin}/mongosh \\"mongodb://0.0.0.0:1\\" 2>&1", 1)
+    assert_match "#ok#", shell_output("#{bin}/mongosh --nodb --eval \\"print('#ok#')\\"")
   end
 end`;
 
@@ -75,8 +75,8 @@ class Mongosh < Formula
   end
 
   test do
-    assert_match "ECONNREFUSED 0.0.0.0:1", shell_output("#{bin}/mongosh \"mongodb://0.0.0.0:1\" 2>&1", 1)
-    assert_match "#ok#", shell_output("#{bin}/mongosh --nodb --eval \"print('#ok#')\"")
+    assert_match "ECONNREFUSED 0.0.0.0:1", shell_output("#{bin}/mongosh \\"mongodb://0.0.0.0:1\\" 2>&1", 1)
+    assert_match "#ok#", shell_output("#{bin}/mongosh --nodb --eval \\"print('#ok#')\\"")
   end
 end`;
     expect(

packages/build/src/homebrew/generate-formula.ts

@@ -11,8 +11,8 @@ export async function generateUpdatedFormula(
     'master'
   );
 
-  const urlMatch = /url \"([^"]+)\"/g.exec(currentFormula.content);
-  const shaMatch = /sha256 \"([^"]+)\"/g.exec(currentFormula.content);
+  const urlMatch = /url "([^"]+)"/g.exec(currentFormula.content);
+  const shaMatch = /sha256 "([^"]+)"/g.exec(currentFormula.content);
 
   if (!urlMatch || !shaMatch) {
     throw new Error(
@@ -45,9 +45,9 @@ export async function generateUpdatedFormula(
   }
 
   let newFormula = currentFormula.content;
-  newFormula = newFormula.replace(/url \"([^"]+)\"/g, `url "${newUrl}"`);
+  newFormula = newFormula.replace(/url "([^"]+)"/g, `url "${newUrl}"`);
   newFormula = newFormula.replace(
-    /sha256 \"([^"]+)\"/g,
+    /sha256 "([^"]+)"/g,
     `sha256 "${context.sha}"`
   );
   return newFormula;

packages/cli-repl/src/crypt-library-paths.ts

@@ -24,6 +24,7 @@ export async function getCryptLibraryPaths(
 ): Promise<CryptLibraryPathResult> {
   const execPath = pretendProcessExecPathForTesting ?? process.execPath;
 
+  // eslint-disable-next-line @typescript-eslint/consistent-type-imports
   let getCryptSharedLibraryVersion: typeof import('mongodb-crypt-library-version');
   try {
     getCryptSharedLibraryVersion = require('mongodb-crypt-library-version');

packages/cli-repl/src/mongosh-repl.ts

@@ -485,6 +485,7 @@ class MongoshNodeRepl implements EvaluationListener {
    *
    * @param _initializationToken A value obtained by calling {@link MongoshNodeRepl.initialize}.
    */
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   async startRepl(_initializationToken: InitializationToken): Promise<void> {
     this.started = true;
     const { repl } = this.runtimeState();

packages/cli-repl/test/fixtures/load/hello1.js

@@ -1 +1,2 @@
+/* eslint-disable no-undef */
 print('hello one');

packages/cli-repl/test/fixtures/load/hello2.js

@@ -1 +1,2 @@
+/* eslint-disable no-undef */
 print('hello two');

packages/cli-repl/test/fixtures/load/insertintotest.js

@@ -1,2 +1,3 @@
+/* eslint-disable no-undef */
 insertTestCollection = db.getSiblingDB('test').getCollection('insertTest' + ((Math.random() * 100000) | 0));
 print('Inserted:', insertTestCollection.insertOne({}).insertedId)

packages/cli-repl/test/fixtures/load/printisinteractive.js

@@ -1 +1,2 @@
+/* eslint-disable no-undef */
 print(`isInteractive=${isInteractive()}`)

packages/e2e-tests/test/e2e-fle.spec.ts

@@ -14,7 +14,6 @@ import { once } from 'events';
 import { serialize } from 'v8';
 import { inspect } from 'util';
 import path from 'path';
-import os from 'os';
 
 describe('FLE tests', function () {
   const testServer = startTestServer('e2e-fle', {

packages/e2e-tests/test/e2e.spec.ts

@@ -454,7 +454,7 @@ describe('e2e', function () {
             }
           });`);
 
-          expect(result).to.match(/Violations\:/);
+          expect(result).to.match(/Violations:/);
           // Two duplicated ids
           expect(result).to.match(/ids: \[\s+ObjectId.+?\s+?ObjectId.+?\s+\]/m);
         });
@@ -695,6 +695,7 @@ describe('e2e', function () {
         skipIfServerVersion(testServer, '<= 4.4');
 
         it('displays errInfo to the user', async function () {
+          /* eslint-disable no-useless-escape */
           await shell.executeLine(`db.createCollection('contacts', {
             validator: {
               $and: [
@@ -704,6 +705,7 @@ describe('e2e', function () {
               ]
             }
           });`);
+          /* eslint-enable no-useless-escape */
           const result = await shell.executeLine(`db.contacts.insertOne({
             email: "test@mongodb.com", status: "Unknown"
           });`);
@@ -716,7 +718,7 @@ describe('e2e', function () {
             validator: {
               $and: [
                 { phone: { $type: "string" } },
-                { email: { $regex: /@mongodb\.com$/ } },
+                { email: { $regex: /@mongodb.com$/ } },
                 { status: { $in: [ "Unknown", "Incomplete" ] } }
               ]
             }

packages/e2e-tests/test/fixtures/exampleplayground.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 // MongoDB Playground
 // To disable this template go to Settings | MongoDB | Use Default Template For Playground.
 // Make sure you are connected to enable completions and to be able to run a playground.

packages/e2e-tests/test/fixtures/load/long-sleep.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 console.log('Long sleep');
 (async() => {
   await sleep(1_000_000);

packages/e2e-tests/test/repl-helpers.ts

@@ -89,7 +89,7 @@ const fakeExternalEditor = async ({
       if (${JSON.stringify(flags ?? '')}) {
         assert.deepStrictEqual((${JSON.stringify(
           flags
-        )}).split(/\s+/), process.argv.slice(2, -1));
+        )}).split(/\\s+/), process.argv.slice(2, -1));
       }
 
       await writeFile(tmpDoc, ${JSON.stringify(output)}, { mode: 0o600 });

packages/editor/src/editor.ts

@@ -146,7 +146,7 @@ export class Editor {
   }
 
   _isVscodeApp(cmd: string): boolean {
-    const regex = /^(.*)[\/\\]?[cC]ode(.exe)?(\s(.*))?$/;
+    const regex = /^(.*)[/\\]?[cC]ode(.exe)?(\s(.*))?$/;
     return regex.test(cmd);
   }
 
@@ -155,7 +155,7 @@ export class Editor {
       return false;
     }
 
-    const regex = /^([^!"#%&'()*+,\-/\[\]\\^`{|}~]+)$/;
+    const regex = /^([^!"#%&'()*+,\-/[\]\\^`{|}~]+)$/;
     return regex.test(code);
   }
 

packages/i18n/src/translator.ts

@@ -66,7 +66,7 @@ class Translator {
    * @param {string} locale - The locale.
    */
   setLocale(locale: string): void {
-    if (MAPPINGS.hasOwnProperty(locale)) {
+    if (Object.prototype.hasOwnProperty.call(MAPPINGS, locale)) {
       this.locale = locale;
       this.catalog = MAPPINGS[locale];
     } else {

packages/logging/src/analytics-helpers.ts

@@ -79,8 +79,8 @@ class Queue<T> {
  * (e.g. because we are running without an API key).
  */
 export class NoopAnalytics implements MongoshAnalytics {
-  identify(_info: any): void {}
-  track(_info: any): void {}
+  identify(): void {}
+  track(): void {}
   flush(cb: () => void) {
     cb();
   }

packages/logging/src/setup-logger-and-telemetry.ts

@@ -113,6 +113,7 @@ export function setupLoggerAndTelemetry(
 
   bus.on('mongosh:connect', function (args: ConnectEvent) {
     const connectionUri = redactURICredentials(args.uri);
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     const { uri: _uri, ...argsWithoutUri } = args;
     const params = {
       session_id: logId,

packages/node-runtime-worker-thread/src/spawn-child-from-source.ts

@@ -25,7 +25,7 @@ export default function spawnChildFromSource(
   _stdout: StdioNull | StdioPipe = 'inherit',
   _stderr: StdioNull | StdioPipe = 'inherit'
 ): Promise<ChildProcess> {
-  return new Promise(async (resolve, reject) => {
+  return new Promise((resolve, reject) => {
     const readyToken = Date.now().toString(32);
 
     const childProcess = spawn(process.execPath, {
@@ -34,11 +34,16 @@ export default function spawnChildFromSource(
     });
 
     if (!childProcess.stdin) {
-      await kill(childProcess);
-
-      return reject(
-        new Error("Can't write src to the spawned process, missing stdin")
-      );
+      kill(childProcess)
+        .then(() => {
+          reject(
+            new Error("Can't write src to the spawned process, missing stdin")
+          );
+        })
+        .catch((err: any) => {
+          reject(err);
+        });
+      return;
     }
 
     // eslint-disable-next-line prefer-const

packages/node-runtime-worker-thread/src/worker-runtime.spec.ts

@@ -91,7 +91,7 @@ describe('worker', function () {
     expect(err).to.be.instanceof(Error);
     expect(err)
       .to.have.property('message')
-      .match(/Can\'t call evaluate before shell runtime is initiated/);
+      .match(/Can't call evaluate before shell runtime is initiated/);
   });
 
   describe('evaluate', function () {
@@ -455,7 +455,7 @@ describe('worker', function () {
         expect(err)
           .to.have.property('message')
           .match(
-            /Can\'t run another evaluation while the previous is not finished/
+            /Can't run another evaluation while the previous is not finished/
           );
       });
     });

packages/node-runtime-worker-thread/src/worker-runtime.ts

@@ -38,7 +38,7 @@ const evaluationLock = new Lock();
 function ensureRuntime(methodName: string): Runtime {
   if (!runtime) {
     throw new Error(
-      `Can\'t call ${methodName} before shell runtime is initiated`
+      `Can't call ${methodName} before shell runtime is initiated`
     );
   }
 

packages/service-provider-core/src/textencoder-polyfill.ts

@@ -10,6 +10,7 @@ if (
   // @ts-ignore
   typeof TextEncoder !== 'function'
 ) {
+  // eslint-disable-next-line @typescript-eslint/no-implied-eval
   Object.assign(Function('return this')(), textEncodingPolyfill());
 }
 

packages/shell-api/src/collection.spec.ts

@@ -1553,12 +1553,14 @@ describe('Collection', function () {
         });
         it('not returned when no args', async function () {
           const result = await collection.stats();
+          // eslint-disable-next-line @typescript-eslint/no-unused-vars
           const { indexDetails, ...expectedResultWithoutIndexDetails } =
             expectedResult;
           expect(result).to.deep.equal(expectedResultWithoutIndexDetails);
         });
         it('not returned when options indexDetails: false', async function () {
           const result = await collection.stats({ indexDetails: false });
+          // eslint-disable-next-line @typescript-eslint/no-unused-vars
           const { indexDetails, ...expectedResultWithoutIndexDetails } =
             expectedResult;
           expect(result).to.deep.equal(expectedResultWithoutIndexDetails);

packages/shell-api/src/field-level-encryption.spec.ts

@@ -36,7 +36,6 @@ import {
   makeFakeHTTPConnection,
   fakeAWSHandlers,
 } from '../../../testing/fake-kms';
-import { inspect } from 'util';
 import Collection from './collection';
 import { dummyOptions } from './helpers.spec';