chore: turn some javascript and typescript lint rules back into errors MONGOSH-1508 #1631
Conversation
| if (${JSON.stringify(flags ?? '')}) { | ||
| assert.deepStrictEqual((${JSON.stringify( | ||
| flags | ||
| // eslint-disable-next-line no-useless-escape |
There was a problem hiding this comment.
I this case I think the no-useless-escape rule was a false positive. It doesn't seem to know about \s.
There was a problem hiding this comment.
It’s because this whole section is inside a template string, so the actual regex ends up being /s+/, which is of course actually wrong.
This might be another good use case for String.raw? Either way, not a false positive
There was a problem hiding this comment.
Aah I see now. OMG that code is hard to read.
packages/node-runtime-worker-thread/src/spawn-child-from-source.ts
Outdated
Show resolved
Hide resolved
| if (${JSON.stringify(flags ?? '')}) { | ||
| assert.deepStrictEqual((${JSON.stringify( | ||
| flags | ||
| // eslint-disable-next-line no-useless-escape |
There was a problem hiding this comment.
It’s because this whole section is inside a template string, so the actual regex ends up being /s+/, which is of course actually wrong.
This might be another good use case for String.raw? Either way, not a false positive
|
|
||
| bus.on('mongosh:connect', function (args: ConnectEvent) { | ||
| const connectionUri = redactURICredentials(args.uri); | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
Really wish these rules would understand underscore-prefixed names or at least some kind of pattern for avoiding false positives 🙂
| if ( | ||
| settings !== null && | ||
| Object.prototype.hasOwnProperty.call(settings, 'activeWindow') | ||
| ) { |
3 participants
I'm leaving or ticketing the rest of the eslint rules that we overrode to be warnings rather than errors.