chore(deps): Add node-gyp version control across different distros MONGOSH-1891 #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Oct 21, 2024
gagik
changed the title
gagik
changed the title
|
I lost and re-found the issue. e2e_tests_linux_x64_60x Setup Failed still happens so probably needs manual handling. Hopefully this last thing works 🤞 |
gagik
changed the title
addaleax
approved these changes
Oct 23, 2024
paula-stacho
approved these changes
Oct 23, 2024
|
Rest of the failing tests seem historically flaky and don't seem to be related to node-gyp so going ahead. |
nirinchev
added a commit
that referenced
this pull request
Oct 25, 2024
* main: chore: update auto-generated files (#2237) feat(shell-api): add shardedDataDistribution to sh.status() MONGOSH-1326 (#2214) chore: update auto-generated files (#2235) feat(tests): Add individual evergreen test results with XUnit (#2227) chore: update auto-generated files (#2234) chore: rename service-provider-server and `CliServiceProvider` (#2232) chore: update auto-generated files (#2233) chore(deps): Add node-gyp version control across different distros MONGOSH-1891 (#2230) chore: update auto-generated files (#2231) fix(shell-api): Align database and collection aggregate functions MONGOSH-1868 (#2229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent CI update likely led to Python being bumped to 3.12+ which means our current node-gyp library can no longer support it without some more manual setup. We need to bump node-gyp and also handle some older dependencies (such as RHEL which should work with 3.6).