chore: rename service-provider-server and CliServiceProvider
#2232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ServiceProvider` is our abstraction for how mongosh interacts with the database. The two notable implementations of that that are actually being used are based on the Node.js driver and the Java driver, respectively. Neither `CliServiceProvider` (has no inherent connection with CLI usage) nor `service-provider-server` (connects to the same servers as any other service provider would) are great names and only reflect the historical architecture for mongosh at this point. So, let's rename this to something that accurately reflects what this service provider implementation is and what distinguishes it from others!
gagik
approved these changes
Oct 23, 2024
nirinchev
added a commit
that referenced
this pull request
Oct 25, 2024
* main: chore: update auto-generated files (#2237) feat(shell-api): add shardedDataDistribution to sh.status() MONGOSH-1326 (#2214) chore: update auto-generated files (#2235) feat(tests): Add individual evergreen test results with XUnit (#2227) chore: update auto-generated files (#2234) chore: rename service-provider-server and `CliServiceProvider` (#2232) chore: update auto-generated files (#2233) chore(deps): Add node-gyp version control across different distros MONGOSH-1891 (#2230) chore: update auto-generated files (#2231) fix(shell-api): Align database and collection aggregate functions MONGOSH-1868 (#2229)
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceProvideris our abstraction for how mongosh interacts with the database.The two notable implementations of that that are actually being used are based on
the Node.js driver and the Java driver, respectively.
Neither
CliServiceProvider(has no inherent connection with CLI usage) norservice-provider-server(connects to the same servers as any other serviceprovider would) are great names and only reflect the historical architecture for
mongosh at this point.
So, let's rename this to something that accurately reflects what this service
provider implementation is and what distinguishes it from others!