chore(cli-repl): fix flaky test and improve errors #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Node.js REPL produces errors like this when a module is not found: ```js Uncaught Error: Cannot find module 'a' Require stack: - <repl> [ ... ] ``` Our test helpers interpreted the `- <repl>` string as a prompt, which it is not. Fix that by requiring the prompt not to contain a matching angle bracket, and provide more precise error messages from our test helpers in general to help debug future problems.
rose-m
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node.js REPL produces errors like this when a module is not found:
Our test helpers interpreted the
- <repl>string as a prompt, whichit is not.
Fix that by requiring the prompt not to contain a matching
angle bracket, and provide more precise error messages from our
test helpers in general to help debug future problems.