Skip to content

chore(cli-repl): fix flaky test and improve errors #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2021
Merged

chore(cli-repl): fix flaky test and improve errors #792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/cli-repl/test/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,10 @@ export async function eventually(fn: Function, options: { frequency?: number; ti
await new Promise(resolve => setTimeout(resolve, options.frequency));
}

Object.assign(err, {
timedOut: true,
timeout: options.timeout,
message: `[Timed out ${options.timeout}ms] ${err.message}`
});
throw err;
}
6 changes: 4 additions & 2 deletions packages/cli-repl/test/test-shell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ import { eventually } from './helpers';
export type TestShellStartupResult = { state: 'prompt' | 'exit'; exitCode?: number | undefined };
type SignalType = ChildProcess extends { kill: (signal: infer T) => any } ? T : never;

const PROMPT_PATTERN = /^([^>]*> ?)+$/m;
// Assume that prompt strings are those that end in '> ' but do not contain
// < or > (so that e.g. '- <repl>' in a stack trace is not considered a prompt).
const PROMPT_PATTERN = /^([^<>]*> ?)+$/m;
const ERROR_PATTERN_1 = /Thrown:\n([^>]*)/mg; // node <= 12.14
const ERROR_PATTERN_2 = /Uncaught[:\n ]+([^>]*)/mg;

Expand Down Expand Up @@ -133,7 +135,7 @@ export class TestShell {
throw new assert.AssertionError({
message: 'expected prompt',
expected: PROMPT_PATTERN.toString(),
actual: this._output
actual: this._output.slice(0, start) + '[prompt search starts here]' + output
});
}
});
Expand Down