Skip to content

RUBY-2863 Split excessive precision exception from out of range exception in Decimal128 #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2021
Merged

RUBY-2863 Split excessive precision exception from out of range exception in Decimal128 #267

merged 2 commits into from
Dec 30, 2021

Conversation

p-mongo
Copy link
Contributor

@p-mongo p-mongo commented Dec 30, 2021 •
edited
Loading

No description provided.

@p-mongo p-mongo changed the title RUBY-2863 2863 RUBY-2863 Split excessive precision exception from out of range exception in Decimal128 Dec 30, 2021
@p-mongo
Copy link
Contributor Author

p-mongo commented Dec 30, 2021

https://jira.mongodb.org/browse/RUBY-2863

neilshweky
neilshweky approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@neilshweky neilshweky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@p-mongo p-mongo merged commit a6f0ac3 into mongodb:master Dec 30, 2021
p-mongo added a commit that referenced this pull request Dec 30, 2021
@p-mongo @p
RUBY-2863 Split excessive precision exception from out of range excep…
4b3d3de 
…tion in Decimal128 (#267)

* RUBY-2863 Split excessive precision exception from out of range exception in Decimal128

* remove @SInCE

Co-authored-by: Oleg Pudeyev <code@olegp.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comandeo comandeo Awaiting requested review from comandeo

1 more reviewer

@neilshweky neilshweky neilshweky approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p-mongo @neilshweky @p