minor: bump clippy to 1.65 (#387)

Author: isabelatkinson

.evergreen/check-clippy.sh

@@ -5,7 +5,7 @@ set -o errexit
 . ~/.cargo/env
 
 # Pin clippy to the latest version. This should be updated when new versions of Rust are released.
-CLIPPY_VERSION=1.63.0
+CLIPPY_VERSION=1.65.0
 
 rustup install $CLIPPY_VERSION
 

src/raw/document_buf.rs

@@ -71,7 +71,7 @@ impl RawDocumentBuf {
     /// Creates a new, empty [`RawDocumentBuf`].
     pub fn new() -> RawDocumentBuf {
         let mut data = Vec::new();
-        data.extend(&MIN_BSON_DOCUMENT_SIZE.to_le_bytes());
+        data.extend(MIN_BSON_DOCUMENT_SIZE.to_le_bytes());
         data.push(0);
         Self { data }
     }
@@ -196,7 +196,7 @@ impl RawDocumentBuf {
     pub fn append(&mut self, key: impl AsRef<str>, value: impl Into<RawBson>) {
         fn append_string(doc: &mut RawDocumentBuf, value: &str) {
             doc.data
-                .extend(&((value.as_bytes().len() + 1) as i32).to_le_bytes());
+                .extend(((value.as_bytes().len() + 1) as i32).to_le_bytes());
             doc.data.extend(value.as_bytes());
             doc.data.push(0);
         }
@@ -220,7 +220,7 @@ impl RawDocumentBuf {
 
         match value {
             RawBson::Int32(i) => {
-                self.data.extend(&i.to_le_bytes());
+                self.data.extend(i.to_le_bytes());
             }
             RawBson::String(s) => {
                 append_string(self, s.as_str());
@@ -237,32 +237,31 @@ impl RawDocumentBuf {
                     subtype: b.subtype,
                 }
                 .len();
-                self.data.extend(&len.to_le_bytes());
+                self.data.extend(len.to_le_bytes());
                 self.data.push(b.subtype.into());
                 if let BinarySubtype::BinaryOld = b.subtype {
-                    self.data.extend(&(len - 4).to_le_bytes())
+                    self.data.extend((len - 4).to_le_bytes())
                 }
                 self.data.extend(b.bytes);
             }
             RawBson::Boolean(b) => {
-                let byte = if b { 1 } else { 0 };
-                self.data.push(byte);
+                self.data.push(b as u8);
             }
             RawBson::DateTime(dt) => {
-                self.data.extend(&dt.timestamp_millis().to_le_bytes());
+                self.data.extend(dt.timestamp_millis().to_le_bytes());
             }
             RawBson::DbPointer(dbp) => {
                 append_string(self, dbp.namespace.as_str());
-                self.data.extend(&dbp.id.bytes());
+                self.data.extend(dbp.id.bytes());
             }
             RawBson::Decimal128(d) => {
-                self.data.extend(&d.bytes());
+                self.data.extend(d.bytes());
             }
             RawBson::Double(d) => {
-                self.data.extend(&d.to_le_bytes());
+                self.data.extend(d.to_le_bytes());
             }
             RawBson::Int64(i) => {
-                self.data.extend(&i.to_le_bytes());
+                self.data.extend(i.to_le_bytes());
             }
             RawBson::RegularExpression(re) => {
                 append_cstring(self, re.pattern.as_str());
@@ -277,15 +276,15 @@ impl RawDocumentBuf {
                     scope: &code_w_scope.scope,
                 }
                 .len();
-                self.data.extend(&len.to_le_bytes());
+                self.data.extend(len.to_le_bytes());
                 append_string(self, code_w_scope.code.as_str());
                 self.data.extend(code_w_scope.scope.into_bytes());
             }
             RawBson::Timestamp(ts) => {
-                self.data.extend(&ts.to_le_i64().to_le_bytes());
+                self.data.extend(ts.to_le_i64().to_le_bytes());
             }
             RawBson::ObjectId(oid) => {
-                self.data.extend(&oid.bytes());
+                self.data.extend(oid.bytes());
             }
             RawBson::Symbol(s) => {
                 append_string(self, s.as_str());

src/ser/mod.rs

@@ -134,9 +134,7 @@ pub(crate) fn serialize_bson<W: Write + ?Sized>(
         Bson::String(ref v) => write_string(writer, v),
         Bson::Array(ref v) => serialize_array(writer, v),
         Bson::Document(ref v) => v.to_writer(writer),
-        Bson::Boolean(v) => writer
-            .write_all(&[if v { 0x01 } else { 0x00 }])
-            .map_err(From::from),
+        Bson::Boolean(v) => writer.write_all(&[v as u8]).map_err(From::from),
         Bson::RegularExpression(Regex {
             ref pattern,
             ref options,

src/ser/raw/mod.rs

@@ -121,7 +121,7 @@ impl<'a> serde::Serializer for &'a mut Serializer {
     #[inline]
     fn serialize_bool(self, v: bool) -> Result<Self::Ok> {
         self.update_element_type(ElementType::Boolean)?;
-        self.bytes.push(if v { 1 } else { 0 });
+        self.bytes.push(v as u8);
         Ok(())
     }
 

src/tests/modules/serializer_deserializer.rs

@@ -322,7 +322,7 @@ fn test_serialize_utc_date_time() {
     #[allow(unused)]
     let src = time::OffsetDateTime::from_unix_timestamp(1_286_705_410).unwrap();
     #[cfg(feature = "chrono-0_4")]
-    let src = chrono::Utc.timestamp(1_286_705_410, 0);
+    let src = chrono::Utc.timestamp_opt(1_286_705_410, 0).unwrap();
     let dst = vec![
         18, 0, 0, 0, 9, 107, 101, 121, 0, 208, 111, 158, 149, 43, 1, 0, 0, 0,
     ];

src/tests/serde.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::blacklisted_name)]
+#![allow(clippy::disallowed_names)]
 
 use crate::{
     bson,