Cached the "_isValueType" information that used to be retrieved through reflection for every Deserialize call

Daniel Hegener · Daniel Hegener · commit 35545b22847d · 2018-10-04T13:58:05.000+02:00
diff --git a/src/MongoDB.Bson/Serialization/Serializers/BsonClassMapSerializer.cs b/src/MongoDB.Bson/Serialization/Serializers/BsonClassMapSerializer.cs
@@ -31,6 +31,7 @@ public class BsonClassMapSerializer<TClass> : SerializerBase<TClass>, IBsonIdPro
     {
         // private fields
         private BsonClassMap _classMap;
+        private bool _isValueType;
 
         // constructors
         /// <summary>
@@ -54,6 +55,7 @@ public BsonClassMapSerializer(BsonClassMap classMap)
             }
 
             _classMap = classMap;
+            _isValueType = _classMap.ClassType.GetTypeInfo().IsValueType;
         }
 
         // public properties
@@ -79,7 +81,7 @@ public override TClass Deserialize(BsonDeserializationContext context, BsonDeser
         {
             var bsonReader = context.Reader;
 
-            if (_classMap.ClassType.GetTypeInfo().IsValueType)
+            if (_isValueType)
             {
                 var message = string.Format("Value class {0} cannot be deserialized.", _classMap.ClassType.FullName);
                 throw new BsonSerializationException(message);

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ public class BsonClassMapSerializer<TClass> : SerializerBase<TClass>, IBsonIdPro`
`31`	`31`	`{`
`32`	`32`	`// private fields`
`33`	`33`	`private BsonClassMap _classMap;`
	`34`	`+ private bool _isValueType;`
`34`	`35`
`35`	`36`	`// constructors`
`36`	`37`	`/// <summary>`
`@@ -54,6 +55,7 @@ public BsonClassMapSerializer(BsonClassMap classMap)`
`54`	`55`	`}`
`55`	`56`
`56`	`57`	`_classMap = classMap;`
	`58`	`+ _isValueType = _classMap.ClassType.GetTypeInfo().IsValueType;`
`57`	`59`	`}`
`58`	`60`
`59`	`61`	`// public properties`
`@@ -79,7 +81,7 @@ public override TClass Deserialize(BsonDeserializationContext context, BsonDeser`
`79`	`81`	`{`
`80`	`82`	`var bsonReader = context.Reader;`
`81`	`83`
`82`		`- if (_classMap.ClassType.GetTypeInfo().IsValueType)`
	`84`	`+ if (_isValueType)`
`83`	`85`	`{`
`84`	`86`	`var message = string.Format("Value class {0} cannot be deserialized.", _classMap.ClassType.FullName);`
`85`	`87`	`throw new BsonSerializationException(message);`