CSHARP-2843: Disable TLS renegotiation when possible #1520
Conversation
| sslStream.AuthenticateAsClient(options); | ||
| #elif (NETSTANDARD2_1_OR_GREATER) | ||
| var options = GetAuthOptions(targetHost); | ||
| sslStream.AuthenticateAsClientAsync(options, default).GetAwaiter().GetResult(); |
There was a problem hiding this comment.
There is no sync version in net2_1. Also the sslstream sync version fallbacks to async.
There was a problem hiding this comment.
The cancellationToken parameter should be passed into AuthenticateAsClientAsync, not a default one.
There was a problem hiding this comment.
Thanks! The older API didn't accept cancellationToken, so this was carried over.
| sslStream.AuthenticateAsClient(options); | ||
| #elif (NETSTANDARD2_1_OR_GREATER) | ||
| var options = GetAuthOptions(targetHost); | ||
| sslStream.AuthenticateAsClientAsync(options, default).GetAwaiter().GetResult(); |
There was a problem hiding this comment.
The cancellationToken parameter should be passed into AuthenticateAsClientAsync, not a default one.
|
|
||
| #if (NETSTANDARD2_1_OR_GREATER || NET6_0_OR_GREATER) | ||
| var options = GetAuthOptions(targetHost); | ||
| await sslStream.AuthenticateAsClientAsync(options, default).ConfigureAwait(false); |
There was a problem hiding this comment.
Same here. The cancellationToken parameter should be passed into AuthenticateAsClientAsync, not a default one.
| @@ -106,6 +122,17 @@ private void DisposeStreamIgnoringExceptions(Stream stream) | |||
| } | |||
| } | |||
|
|
|||
| #if (NETSTANDARD2_1_OR_GREATER || NET6_0_OR_GREATER) | |||
| private SslClientAuthenticationOptions GetAuthOptions(string targetHost) => new() | |||
There was a problem hiding this comment.
We typically avoid abbreviations. GetAuthenticationOptions or GetSslClientAuthenticationOptions.
No description provided.