CXX-2039 Add VS2019 support and migrate VS2017 tasks to windows-vsCurrent distro #1082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-2039. Verified by this patch.
This PR primarily consists of three steps:
windows-64-vs2017
towindows-vsCurrent
.This should also address the spurious "cygheap base mismatch detected" failures on Evergreen due to BUILD-17907, which were frequently observed on the
windows-64-vs2017
distro (VS 2015 tasks thankfully seem to be unaffected?).As part of this effort, several drive-by improvements are made to the EVG config and scripts:
CMAKE_GENERATOR_PLATFORM
or-A
to specify the generator platform rather than theWin64
generator suffix (which only exists for pre-CMake 3.1 compatibility and is not supported by the VS 2019 generator or newer). Documentation and examples were updated accordingly.cmake --build
command).This PR initially proposes a simple duplication of the existing VS 2017 tasks with VS 2019 instead. If preferable, the set of tasks and coverage between the VS 2017 and VS 2019 tasks can be adjusted to reduce redundancy.
Note: this PR does not extend C++20 compile coverage to VS 2019, nor does it extend test coverage to VS 2022 (which is available on the new distro).