Prioritize electionId over setVersion on 6.0+ servers #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
commented
Oct 5, 2022
driver-core/src/main/com/mongodb/internal/connection/AbstractMultiServerCluster.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/AbstractMultiServerCluster.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/AbstractMultiServerCluster.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/AbstractMultiServerCluster.java
Outdated
Show resolved
Hide resolved
nbbeeken
reviewed
Oct 6, 2022
driver-core/src/main/com/mongodb/internal/connection/AbstractMultiServerCluster.java
Outdated
Show resolved
Hide resolved
nbbeeken
approved these changes
Oct 6, 2022
stIncMale
requested changes
Oct 12, 2022
driver-core/src/main/com/mongodb/internal/connection/AbstractMultiServerCluster.java
Outdated
Show resolved
Hide resolved
|
@stIncMale ready for re-review |
stIncMale
requested changes
Oct 13, 2022
There was a problem hiding this comment.
The new code is so much better than the version I reviewed the first time! 👏 I still have a couple of readability concerns, which may be caused by my stupidity / lack of knowledge, but if the proposed code is as readable to you as the current code, it'd be great to apply the proposed changes, because to me it drastically affects the readability.
driver-core/src/main/com/mongodb/internal/connection/AbstractMultiServerCluster.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/AbstractMultiServerCluster.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/AbstractMultiServerCluster.java
Outdated
Show resolved
Hide resolved
|
@stIncMale ready for review |
stIncMale
approved these changes
Oct 13, 2022
ispringer
pushed a commit
to evergage/mongo-java-driver
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4707