Encapsulate ChangeStreamOperation #1029
Conversation
JAVA-4795
|
|
||
| public <TResult> AsyncReadOperation<AsyncBatchCursor<TResult>> changeStream(final FullDocument fullDocument, | ||
| final FullDocumentBeforeChange fullDocumentBeforeChange, final List<? extends Bson> pipeline, | ||
| final Decoder<TResult> decoder, final ChangeStreamLevel changeStreamLevel, final Integer batchSize, final Collation collation, |
There was a problem hiding this comment.
It's odd that we have to pass in the decoder rather than just a result class, but it turns out there's slight difference in implementation between sync and async that requires this, and I didn't think this is the time to resolve the difference.
There was a problem hiding this comment.
I see that we also pass a decoder to SyncOperations.changeStream for the same reason: ChangeStreamOperation needs it. And then I see ChangeStreamOperation.getDecoder being used in ChangeStreamBatchCursor, which tells me that the decoder is used by both sync and async code. I don't think I understand what you are pointing to.
There was a problem hiding this comment.
Let me know if you want me to dig into this and explain it. I no longer remember.
There was a problem hiding this comment.
I don't know whether that was important or not. But given that the approach was to ignore that anyway, there is probably no reason to try and dig that out again.
|
|
||
| public <TResult> AsyncReadOperation<AsyncBatchCursor<TResult>> changeStream(final FullDocument fullDocument, | ||
| final FullDocumentBeforeChange fullDocumentBeforeChange, final List<? extends Bson> pipeline, | ||
| final Decoder<TResult> decoder, final ChangeStreamLevel changeStreamLevel, final Integer batchSize, final Collation collation, |
There was a problem hiding this comment.
I see that we also pass a decoder to SyncOperations.changeStream for the same reason: ChangeStreamOperation needs it. And then I see ChangeStreamOperation.getDecoder being used in ChangeStreamBatchCursor, which tells me that the decoder is used by both sync and async code. I don't think I understand what you are pointing to.
|
Approved, but we need green tests. |
|
Tests are green |
JAVA-4795