Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add end-to-end Search Index Management Helper Methods Tests #1184

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Add end-to-end Search Index Management Helper Methods Tests #1184

merged 4 commits into from
Aug 31, 2023

Conversation

vbabanin
Copy link
Member

@jyemin jyemin requested review from rozza and removed request for katcharov August 29, 2023 14:44
rozza
rozza reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vbabanin,

One nit for the evergreen file but its looking good. The default PR evergreen tests are limited so could you also post a link to an evergreen patch build that runs the "Atlas Search Index Management Tests"?

Ross

.evergreen/.evg.yml Outdated
@@ -2029,6 +2066,12 @@ buildvariants:
tasks:
- name: "plain-auth-test"

- name: rhel80-test-search-indexes
display_name: Atlas Search Index Management Tests
run_on: rhel80-large
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Recommend: rhel80-small unless theres a reason to use the larger server.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed to a smaller instance, thanks!

@vbabanin
Copy link
Member Author

vbabanin commented Aug 29, 2023 •
edited

Hi @vbabanin,

One nit for the evergreen file but its looking good. The default PR evergreen tests are limited so could you also post a link to an evergreen patch build that runs the "Atlas Search Index Management Tests"?

Ross

Hi Ross, thanks for reviewing. Here is the link: Evergreen
These tests are included in this PR patch.

@vbabanin vbabanin requested a review from rozza August 31, 2023 05:51
rozza
rozza approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vbabanin vbabanin merged commit dcd03d0 into mongodb:master Aug 31, 2023
57 checks passed
@vbabanin vbabanin deleted the JAVA-5037 branch August 31, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozza rozza rozza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vbabanin @rozza