Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect test-skipping logic #1186

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Remove incorrect test-skipping logic #1186

merged 4 commits into from
Aug 31, 2023

Conversation

jyemin
Copy link
Contributor

@jyemin jyemin commented Aug 29, 2023

@jyemin jyemin requested a review from rozza August 29, 2023 22:50
@jyemin jyemin self-assigned this Aug 29, 2023
@jyemin jyemin marked this pull request as ready for review August 29, 2023 22:52
@jyemin jyemin removed the request for review from rozza August 29, 2023 23:33
@jyemin jyemin requested a review from rozza August 30, 2023 22:37
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overwritten minServerVersions will cause issues once the json files are synced.

It may be easier to add a check in setup(), then you can link to the ticket as well:

Psuedo-code:

// TODO - SEE: JAVA-5125
if (!isDiscoverableReplicaSet()) { 
   assumeTrue(isAtleastServerVersionFiveDotZero);
}

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jyemin jyemin merged commit d08adff into mongodb:master Aug 31, 2023
54 of 56 checks passed
@jyemin jyemin deleted the j5124 branch August 31, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants