Skip to content

Exclude :graalvm-native-image-app from being published #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

stIncMale
Copy link
Member

@stIncMale stIncMale commented Apr 10, 2024

Tested by manually doing the following:

  • rm -r ~/.m2/repository/org/mongodb
  • rm -r ./build/docs
  • ./gradlew clean docs publishToMavenLocal -x signMavenJavaPublication
    • check that ./build/docs/bson exists and ./build/docs/graalvm-native-image-app does not.
  • check that ~/.m2/repository/org/mongodb/bson exists and ~/.m2/repository/org/mongodb/graalvm-native-image-app does not.

JAVA-5414

@stIncMale stIncMale self-assigned this Apr 10, 2024
@stIncMale stIncMale requested a review from jyemin April 10, 2024 21:59
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also this line in build.gradle:

def javaCodeCheckedProjects = javaMainProjects.findAll { !['driver-benchmarks', 'driver-workload-executor', 'driver-lambda'].contains(it.name) }

and this in gradle/javadoc.gradle:

def projectsThatDoNotPublishJavaDocs = project(":util").allprojects + project(":driver-benchmarks") + project("driver-workload-executor") + project("driver-lambda")

I think graalvm-native-image-app should be added in those places too.

@stIncMale
Copy link
Member Author

stIncMale commented Apr 10, 2024

Thanks! I agree about projectsThatDoNotPublishJavaDocs, as all the javadocs get generated in the same place, not in build subdirectories of each project. However, I don't think javaCodeCheckedProjects needs to be updated - there is nothing wrong with :graalvm-native-image-app being statically checked. The checks still seem valuable, despite the code not being intended for production.

@stIncMale stIncMale requested a review from jyemin April 10, 2024 22:34
@stIncMale stIncMale merged commit 7bf5ec2 into mongodb:master Apr 11, 2024
@stIncMale stIncMale deleted the JAVA-5414 branch April 11, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants