Added a new MongoOption: maxConnectionRetryTime #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses openssl directly, only if the sha1sum shortcut doesn't exist.
If the Mongo server goes down completely, you may want to have control over the total amount of time you wait to connect to it before failing. The existing connectTimeout and socketTimeout values don't have any real effect on that; decreasing them doesn't change the fact that DBPort will still keep retrying until you've spent CONN_RETRY_TIME_MS milliseconds. This change lets you (optionally) configure that value from its default of 15000.
|
thanks the feature was ported to trunk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new option for connecting to a Mongo database: maxConnectionRetryTime. This allows you to configure the total amount of time you spend retrying a request if the Mongo server is completely down. Setting the socketTimeout and connectTimeout don't work for that; it'll just keep retrying for the same amount of time regardless because DBPort will keep going until you've expended CONN_RETRY_TIME_MS.
This change allows you to (optionally) configure that value. It's backwards-compatible; if you don't do anything, it continues to use the old value (15000).
Also included in this pair of commits: a change to mavenPush.py to let it run on systems that don't have the "sha1sum" program available. I'm on Snow Leopard, and "sha1sum" doesn't exist. The new mavenPush.py will use sha1sum if it's available, and if not will use openssl directly to determine the SHA-1 hash of the jar file.