-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Docs: Update for latest Hugo and fix whitespace #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -3,7 +3,7 @@ | |||
The static front page site for the Java documentation portal. | |||
|
|||
## Requirements | |||
Hugo version 0.13 [download here](https://github.com/spf13/hugo/releases/tag/v0.13) | |||
Hugo version 0.21 [download here](https://github.com/spf13/hugo/releases/tag/v0.21) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to the latest Hugo version 0.21
@@ -2,5 +2,7 @@ baseurl = "/mongo-java-driver/" | |||
languageCode = "en-us" | |||
title = "MongoDB Java Driver" | |||
canonifyurls = false | |||
disableHugoGeneratorInject = true | |||
disableKinds = ["section", "taxonomy", "taxonomyTerm", "404"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hugo 0.18 broke directory/index.md
. So turning off section and taxonomy type pages fixed the issue. I also disabled the 404 page as it isn't used. Only the top level 404 page is used and there isnt a mongodb/mongodb
repo with gh-pages so there isnt a custom 404 page.
@@ -2,7 +2,7 @@ | |||
<html lang="en"> | |||
<head> | |||
{{ partial "meta.html"}} | |||
<link rel="shortcut icon" href="{{.Site.BaseUrl}}/img/favicon.png"> | |||
<link rel="shortcut icon" href="{{.Site.BaseURL}}/img/favicon.png"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other braking changes was Url
=> URL
@@ -1,34 +1,34 @@ | |||
<!DOCTYPE html> | |||
<html lang="en"> | |||
<head> | |||
{{ partial "meta.html"}} | |||
<link rel="shortcut icon" href="{{.Site.BaseUrl}}/s/img/favicon.png"> | |||
{{- partial "meta.html" -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go added whitespace trimming into its template language and now the reference index page size has been reduced from over 3000 lines to 350.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JAVA-2518