Skip to content

JAVA-3839 #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 15, 2020
Merged

JAVA-3839 #576

merged 6 commits into from
Sep 15, 2020

Conversation

jyemin
Copy link
Collaborator

@jyemin jyemin commented Sep 11, 2020

@rozza this is preliminary work as the Scala build fails when running against Java 14. See https://jira.mongodb.org/browse/JAVA-3839 for the exception I get. I found sbt/sbt#5093 but I'm not sure what, if anything, can be updated in our build script to take advantage of the fix. Can you take a look?

Several more rules were added, which are excluded in codenarc.xml

JAVA-3839
@jyemin jyemin requested a review from rozza September 11, 2020 17:10
@jyemin jyemin marked this pull request as draft September 11, 2020 17:10
@jyemin jyemin self-assigned this Sep 11, 2020
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update gradle.properties:

scalaVersions=2.11.12,2.12.12,2.13.3
defaultScalaVersions=2.13.3

See: https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html#version-compatibility-table

You'll have to edit the publishing the scala snapshots / archives and set the jdk to 11 for the 2.11 & 2.12 versions of scala.

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Should be 2.13.3

@jyemin jyemin requested a review from rozza September 15, 2020 12:56
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jyemin
Copy link
Collaborator Author

jyemin commented Sep 15, 2020

Added one more update to fix an issue when using Java 15.

@jyemin jyemin marked this pull request as ready for review September 15, 2020 14:04
@jyemin jyemin merged commit 9e91ef3 into mongodb:master Sep 15, 2020
@jyemin jyemin deleted the j3839 branch September 15, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants