Skip to content

[JAVA-3814] Supports BsonIgnore annotation for scala driver #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

gael-ft
Copy link
Contributor

@gael-ft gael-ft commented Sep 28, 2020

Link to JIRA issue here

Goal is to support BsonIgnore annotation for scala driver in order to ignore some fields during bson serialization which are not meant to be Options

ie:

case class Person(firstname: String, lastname: String, @BsonIgnore metadata: Seq[Metadata] = Vector())

Tests have been added to the MacrosSpec

@gael-ft
Copy link
Contributor Author

gael-ft commented Oct 9, 2020

Hi @rozza @jyemin,

First, I am sorry to tag you directly, but it looks like you're the developers of this repository.

I would just like to know if this PR will be reviewed / merged at some point, if I did something wrong in it (I can see in CONTRIBUTING.md that it can be ignored for some reasons), or simply if this kind of feature is not desired in the library.

Thank you

@rozza
Copy link
Member

rozza commented Oct 9, 2020

Hi @gael-ft thanks for the PR and the nudge!

Apologies for not responding sooner, this looks really good, I've scheduled it for the 4.2 release and will review and merge in due course.

All the best,

Ross

@gael-ft
Copy link
Contributor Author

gael-ft commented Jan 12, 2021

Hello @rozza,

I can see there is a 4.2.0-beta1 ongoing, did you have time to review this PR ?

Do you think it could be integrated in the 4.2.0 ?

Thanks

@rozza
Copy link
Member

rozza commented Jan 12, 2021

Hi @gael-ft, happy new year. Just to let you know I plan to review with a mind to merge this week.

@gael-ft
Copy link
Contributor Author

gael-ft commented Jan 12, 2021

Ok @rozza, thank you.

(My apologizies, for the previous message, happy new year too !)

@rozza rozza merged commit f81cc87 into mongodb:master Jan 12, 2021
@rozza
Copy link
Member

rozza commented Jan 12, 2021

Thanks @gael-ft this has now been merged to master.

jfitzu pushed a commit to nextworld-tools/mongo-java-driver that referenced this pull request Mar 3, 2021
jfitzu added a commit to nextworld-tools/mongo-java-driver that referenced this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants