Skip to content

Close server/pool in LoadBalancedCluster and LoadBalancedServer respectively #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 27, 2021
Merged

Close server/pool in LoadBalancedCluster and LoadBalancedServer respectively #720

merged 5 commits into from
May 27, 2021

Conversation

stIncMale
Copy link
Member

@stIncMale stIncMale requested a review from jyemin May 25, 2021 21:43
@jyemin jyemin self-requested a review May 25, 2021 22:50
jyemin
jyemin approved these changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stIncMale stIncMale requested a review from jyemin May 25, 2021 23:09
jyemin
jyemin reviewed May 26, 2021
View reviewed changes
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Did you find the bug just by code inspection?

I think it would be possible to write a unit test asserting this behavior. What do you think?

@stIncMale
Copy link
Member Author

Did you find the bug just by code inspection?

Yes.

I think it would be possible to write a unit test asserting this behavior.

Added the test in f899e16.

@stIncMale stIncMale requested a review from jyemin May 27, 2021 00:04
@stIncMale stIncMale requested a review from jyemin May 27, 2021 15:20
jyemin
jyemin approved these changes May 27, 2021
View reviewed changes
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the tests.

@stIncMale stIncMale merged commit 105cf7a into mongodb:master May 27, 2021
@stIncMale stIncMale deleted the JAVA-4178 branch May 27, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyemin jyemin jyemin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stIncMale @jyemin