-
Notifications
You must be signed in to change notification settings - Fork 1.5k
JAVA-4421: Remove errorLabels from WriteConcernError #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just in case, I am throwing everything that comes to mind regarding running the tests locally:
|
Thanks! I was running my DB on a different port and was under the impression that it was on 27017. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should I be passing in an empty error labels BsonArray
Yes, might as well, since right after that the errorLabels are added
* @param writeConcernError the non-null write concern error | ||
* @param writeConcernResult the write result | ||
* @param serverAddress the non-null server address | ||
* @since 3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change from 3.2 to 4.5
driver-core/src/main/com/mongodb/MongoWriteConcernException.java
Outdated
Show resolved
Hide resolved
@@ -35,7 +35,7 @@ | |||
private final String codeName; | |||
private final String message; | |||
private final BsonDocument details; | |||
private final Set<String> errorLabels; | |||
@Deprecated private final Set<String> errorLabels; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to the getter and add an @deprecated
Javadoc tag.
driver-core/src/main/com/mongodb/internal/operation/WriteConcernHelper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added @Deprecated
tags where necessary.
JAVA-4421