Skip to content

Conversation

stIncMale
Copy link
Member

@stIncMale stIncMale commented Jun 15, 2022

If you are wondering about a test that fails without this change, look at the SearchOperatorTest.of test, which was modified with a new scenario that requires the changes in this PR.

This is a prerequisite for JAVA-4394, which is almost done, but needs this change.

JAVA-4190

@stIncMale stIncMale requested review from rozza and jyemin June 15, 2022 07:22
@stIncMale stIncMale self-assigned this Jun 15, 2022
@stIncMale
Copy link
Member Author

stIncMale commented Jun 15, 2022

@jyemin, I combined the new constructible BSON element class with the one we had originally as you proposed. So now we have only AbstractConstructibleBsonElement, just like before this PR.

Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification. LGTM.

@stIncMale stIncMale removed the request for review from rozza June 16, 2022 18:11
@stIncMale stIncMale merged commit b0ceebb into mongodb:master Jun 16, 2022
@stIncMale stIncMale deleted the fixSeachOfMethodsForBsonElements branch June 16, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants