Skip to content

Conversation

heli-os
Copy link

@heli-os heli-os commented Aug 30, 2022

open the PR of typo correction too. However, changes have occurred in the abstraction code and the implementation code.

so i open a new PR

--
I understood it to only open issues for features or bugs.
so,,, should i open an issue? if so, please tell me 🙇

@jyemin
Copy link
Collaborator

jyemin commented Sep 13, 2022

While I'd love to merge this, as I hate spelling errors, the problem is that the error is in the spelling of a public method, and fixing it would break binary compatibility with existing applications that are depending on the current, misspelled name.

So I'm going to have to close this without merging. But thanks for finding it, and feel free to open PRs for misspellings outside of the public interface of the driver.

@jyemin jyemin closed this Sep 13, 2022
@heli-os
Copy link
Author

heli-os commented Sep 13, 2022

@jyemin I know what you mean. thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants