This repository was archived by the owner on Dec 22, 2021. It is now read-only.
PERL-805 Implement database enumeration spec #146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdg
suggested changes
Dec 13, 2017
Contributor
xdg
left a comment
xdg
left a comment
There was a problem hiding this comment.
Looks pretty good. Just a couple minor changes, please.
| my @dbs = $client->database_names; | ||
| List of all database names on the MongoDB server. Supports filters in the same | ||
| way as L</"list_databases">. |
Contributor
There was a problem hiding this comment.
Please add an example here as well for clarity.
t/enumerate_databases.t
Outdated
| } | ||
| my @all_dbs = $conn->list_databases; | ||
|
|
||
| ok( scalar( @all_dbs ) > 6, "Found at least 6 databases" ); |
Contributor
There was a problem hiding this comment.
>= 6 here? Usually there would be 'admin' and 'test', but let's not make that assumption.
t/enumerate_databases.t
Outdated
|
|
||
| for my $prefix ( qw/ foo bar baz / ) { | ||
| my $db1 = $conn->get_database( $prefix . $time_prefix . int(rand(99999)) ) or die "Can't get database\n"; | ||
| my $db2 = $conn->get_database( $prefix . $time_prefix . int(rand(99999)) ) or die "Can't get database\n"; |
Contributor
There was a problem hiding this comment.
Instead of getting databases this way, how about having get_test_db take an optional prefix (defaulting to 'testdb') and using that? That would have the added advantage of registering the databases for cleanup in the END step, which would mean you can remove lines 74-76.
t/enumerate_databases.t
Outdated
| my $time_prefix = time(); | ||
|
|
||
| for my $prefix ( qw/ foo bar baz / ) { | ||
| my $db1 = $conn->get_database( $prefix . $time_prefix . int(rand(99999)) ) or die "Can't get database\n"; |
Contributor
|
Squashed and merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.