Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

Conversation

@phaylon
Copy link
Contributor

@phaylon phaylon commented Apr 5, 2018

This performs the actual inserts/updates/deletes in-between the example snippets, since only the $cursor->next is repeated.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.678% when pulling 380a09e on shadow-dot-cat:phaylon/PERL-809 into e694f23 on mongodb:master.

Copy link
Contributor

@xdg xdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have minor nits but I'll fix it up as I squash and rebase.

#<<< No perltidy

subtest "change streams" => sub {
plan skip_all => '$currentDate operator requires MongoDB 2.6+'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/2.6/3.6/

$document = $cursor->next;
# End Changestream Example 1

is $document, undef, 'no changes after example 2';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/example 2/example 1/

@xdg
Copy link
Contributor

xdg commented Apr 11, 2018

Rebased, amended and merged in cdf16bc

@xdg xdg closed this Apr 11, 2018
@TBSliver TBSliver deleted the phaylon/PERL-809 branch June 13, 2019 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants