PERL-793: Causal Consistency #153
Conversation
TBSliver
force-pushed
the
TBSliver/PERL-793
branch
from
8342452 to
51a35f4
Compare
lib/MongoDB/ClientSession.pm
Outdated
| updated to this provided value. | ||
| Setting C<operation_time> with a manually crafted value may cause a server | ||
| error. It is reccomended to only use an C<operation_time> retreived from |
| # * count | ||
| # * distinct | ||
|
|
||
| subtest 'find' => sub { |
There was a problem hiding this comment.
These are a bit repetitive. How about setting up an array of method name + args tuples and then having the test logic in a loop?
| # * ordered_bulk | ||
| # * unordered_bulk | ||
|
|
||
| subtest 'insert_one' => sub { |
There was a problem hiding this comment.
Ditto about setting up an array of methods and arguments and looping the test logic. (Except for bulk -- those can stay separate.)
|
Looks very good. Just a few minor changes in what I see here. Also, however, please do the following:
|
TBSliver
force-pushed
the
TBSliver/PERL-793
branch
from
ae64614 to
442d007
Compare
|
Looks good. Just waiting on the command monitoring bits. I'll take care of resolving the conflicts later before I merge it. |
|
Right, thats the command monitoring stuff in. Have also renamed the test to not have the ticket name as you mentioned in #159 for PERL-792 |
|
LGTM. I'll start working on getting it rebased and merged. |
|
Rebased, fixed up and merged. Thanks! |
3 participants
Adds support for causal consistency on sessions. Note that from the Spec, tests 7, 11, and 12 are not implemented as the tests are either logically impossible, or are covered in tests from PERL-790.
Also note this includes a fix for session support in explain on a cursor.