This repository was archived by the owner on Dec 22, 2021. It is now read-only.
PERL-782 - Test maxTimeMS is an accepted option... #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and drop_all. API Changes: * Last value of create_many is now an optional hash reference with global options. * create_one received an additional maxTimeMS option. * drop_one and drop_all now accept an options hash reference with maxTimeMS.
xdg
suggested changes
May 2, 2018
Contributor
xdg
left a comment
xdg
left a comment
There was a problem hiding this comment.
Please document the maxTimeMS option for create_one.
Please move the tests into t/max_time_ms.t -- all those failpoint tests can't be run in parallel so the should be pulled into t/max_time_ms.t which is forced to serialize. (See t/testrules.yml)
Otherwise, looks good! Thanks!
Contributor
Author
|
Fixed and rebased in PR 157. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add maxTimeMS option to IndexView's create_one, create_many, drop_one and drop_all.
API Changes: