PERL-970 Allow BSON::Doc as sort argument #174
Conversation
xdg
left a comment
xdg
left a comment
There was a problem hiding this comment.
Unless there's a particular reason to have a new .t file, I think the tests there should just wind up in t/collection.t.
lib/MongoDB/Collection.pm
Outdated
| elsif ( $type eq 'ARRAY' ) { | ||
| $hash->{$key} = Tie::IxHash->new( @$ref ); | ||
| } | ||
| elsif ( $ref->$_can('_as_tied_hash') ) { |
There was a problem hiding this comment.
Problem with this is that even though it works, it's not an technically a Tie::IxHash. (I'm sure later code converts it.) I think you can just inline what __as_tied_hash does, ie. dereferencing the object to a list of key/value pairs to pass to the IxHash constructor. Doing that is no worse than using the private method. :-)
There was a problem hiding this comment.
Yea later code does convert it - putting return if $type eq 'BSON::Doc'; works as well... have added it as a logical or to the ARRAY type, as its identical conversion.
TBSliver
force-pushed
the
TBSliver/PERL-970
branch
from
5b503be to
bd744e6
Compare
Also move tests for sorting by BSON::Doc into collection.t
|
Have moved the tests to the end of collection.t and inlined the IxHash conversion for BSON::Doc |
3 participants
BSON::Docprovides a_as_tied_hashfunction, so uses that. Also has side effect that anything with that function will work for the argument. Includes test for making sure it doesnt explode and actually works.