PHPC-240: Cannot iterate beyond command cursor's first batch

[jmikola]

https://jira.mongodb.org/browse/PHPC-240

[jmikola]

I suggested removing this because, after simplifying our iteration handlers, it would only be used in the Cursor's debug handler.

[bjori]

lgtm

[bjori]

After reading the cursor-iterator_handlers-001.phpt testcase, I think we have to throw an exception in rewind() if the cursor has been iterated over, or in the middle of iteration.
Repeated calls to rewind() without next() in between is fine (although doesn't make a lot of sense), but after iteration has started a call to rewind() really has to throw OutOfBoundsException.

It is really confusing if calling rewind() is somewhat of a NOOP and you can continue stepping through some parts of it.

rewind($cursor); $first = current($cursor); next($cursor);
rewind($cursor); $firstAgain = current($cursor);

$first must be == $firstAgain

And since cannot do that without re-executing the query, which we clearly don't want to do -- I think we must throw an exception.

[bjori]

Since you are adding tests for this -- maybe add one test where the results fit nicely within the batchSize?

[derickr]

I think calling rewind more than once (even when no next() is called), should throw that exception.

[bjori]

lgtm -- see also https://jira.mongodb.org/browse/PHPC-255