PHPC-240: Cannot iterate beyond command cursor's first batch #37
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| --TEST-- | ||
| MongoDB\Driver\Cursor query result iteration with batchSize requiring getmore with full batches | ||
| --SKIPIF-- | ||
| <?php require __DIR__ . "/../utils/basic-skipif.inc"; CLEANUP(STANDALONE) ?> | ||
| --FILE-- | ||
| <?php | ||
| require_once __DIR__ . "/../utils/basic.inc"; | ||
|
|
||
| $manager = new MongoDB\Driver\Manager(STANDALONE); | ||
|
|
||
| $bulkWrite = new MongoDB\Driver\BulkWrite; | ||
|
|
||
| for ($i = 0; $i < 6; $i++) { | ||
| $bulkWrite->insert(array('_id' => $i)); | ||
| } | ||
|
|
||
| $writeResult = $manager->executeBulkWrite(NS, $bulkWrite); | ||
| printf("Inserted: %d\n", $writeResult->getInsertedCount()); | ||
|
|
||
| $cursor = $manager->executeQuery(NS, new MongoDB\Driver\Query(array(), array('batchSize' => 2))); | ||
|
|
||
| foreach ($cursor as $i => $document) { | ||
| printf("%d => {_id: %d}\n", $i, $document['_id']); | ||
| } | ||
|
|
||
| ?> | ||
| ===DONE=== | ||
| <?php exit(0); ?> | ||
| --EXPECT-- | ||
| Inserted: 6 | ||
| 0 => {_id: 0} | ||
| 1 => {_id: 1} | ||
| 2 => {_id: 2} | ||
| 3 => {_id: 3} | ||
| 4 => {_id: 4} | ||
| 5 => {_id: 5} | ||
| ===DONE=== | ||
|
There was a problem hiding this comment. Since you are adding tests for this -- maybe add one test where the results fit nicely within the batchSize? |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| --TEST-- | ||
| MongoDB\Driver\Cursor query result iteration with batchSize requiring getmore with non-full batches | ||
| --SKIPIF-- | ||
| <?php require __DIR__ . "/../utils/basic-skipif.inc"; CLEANUP(STANDALONE) ?> | ||
| --FILE-- | ||
| <?php | ||
| require_once __DIR__ . "/../utils/basic.inc"; | ||
|
|
||
| $manager = new MongoDB\Driver\Manager(STANDALONE); | ||
|
|
||
| $bulkWrite = new MongoDB\Driver\BulkWrite; | ||
|
|
||
| for ($i = 0; $i < 5; $i++) { | ||
| $bulkWrite->insert(array('_id' => $i)); | ||
| } | ||
|
|
||
| $writeResult = $manager->executeBulkWrite(NS, $bulkWrite); | ||
| printf("Inserted: %d\n", $writeResult->getInsertedCount()); | ||
|
|
||
| $cursor = $manager->executeQuery(NS, new MongoDB\Driver\Query(array(), array('batchSize' => 2))); | ||
|
|
||
| foreach ($cursor as $i => $document) { | ||
| printf("%d => {_id: %d}\n", $i, $document['_id']); | ||
| } | ||
|
|
||
| ?> | ||
| ===DONE=== | ||
| <?php exit(0); ?> | ||
| --EXPECT-- | ||
| Inserted: 5 | ||
| 0 => {_id: 0} | ||
| 1 => {_id: 1} | ||
| 2 => {_id: 2} | ||
| 3 => {_id: 3} | ||
| 4 => {_id: 4} | ||
| ===DONE=== |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| --TEST-- | ||
| MongoDB\Driver\Cursor command result iteration with batchSize requiring getmore with full batches | ||
| --SKIPIF-- | ||
| <?php require __DIR__ . "/../utils/basic-skipif.inc"; CLEANUP(STANDALONE) ?> | ||
| --FILE-- | ||
| <?php | ||
| require_once __DIR__ . "/../utils/basic.inc"; | ||
|
|
||
| $manager = new MongoDB\Driver\Manager(STANDALONE); | ||
|
|
||
| $bulkWrite = new MongoDB\Driver\BulkWrite; | ||
|
|
||
| for ($i = 0; $i < 6; $i++) { | ||
| $bulkWrite->insert(array('_id' => $i)); | ||
| } | ||
|
|
||
| $writeResult = $manager->executeBulkWrite(NS, $bulkWrite); | ||
| printf("Inserted: %d\n", $writeResult->getInsertedCount()); | ||
|
|
||
| $command = new MongoDB\Driver\Command(array( | ||
| 'aggregate' => COLLECTION_NAME, | ||
| 'pipeline' => array( | ||
| array('$match' => new stdClass), | ||
| ), | ||
| 'cursor' => array('batchSize' => 2), | ||
| )); | ||
|
|
||
| $cursor = $manager->executeCommand(DATABASE_NAME, $command); | ||
|
|
||
| foreach ($cursor as $i => $document) { | ||
| printf("%d => {_id: %d}\n", $i, $document['_id']); | ||
| } | ||
|
|
||
| ?> | ||
| ===DONE=== | ||
| <?php exit(0); ?> | ||
| --EXPECT-- | ||
| Inserted: 6 | ||
| 0 => {_id: 0} | ||
| 1 => {_id: 1} | ||
| 2 => {_id: 2} | ||
| 3 => {_id: 3} | ||
| 4 => {_id: 4} | ||
| 5 => {_id: 5} | ||
| ===DONE=== |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested removing this because, after simplifying our iteration handlers, it would only be used in the Cursor's debug handler.