Skip to content

PHPC-714: BSON corpus tests #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 13, 2017
Merged

PHPC-714: BSON corpus tests #440

merged 3 commits into from
Jan 13, 2017

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Oct 17, 2016

https://jira.mongodb.org/browse/PHPC-714

Also, various corpus test cases currently fail. This is likely due to libbson, so we may want to hold off until the C driver implements these tests. I expect that at least some issues cannot be resolved without breaking BC.

@derickr
Copy link
Contributor

derickr commented Oct 18, 2016

So is this still WIP?

@jmikola jmikola changed the title PHPLIB-714: BSON corpus tests [WIP] PHPLIB-714: BSON corpus tests Oct 18, 2016
@jmikola
Copy link
Member Author

jmikola commented Oct 18, 2016

So is this still WIP?

Changed it to WIP. I need to group the specific failures so we can relay those to the C driver team and then update the tests to XFAIL.

@jmikola jmikola force-pushed the phpc-714 branch 2 times, most recently from f4b8922 to 838a305 Compare December 27, 2016 21:55
@jmikola jmikola force-pushed the phpc-714 branch 2 times, most recently from 661f810 to b6dcdcd Compare December 29, 2016 22:11
@jmikola
Copy link
Member Author

jmikola commented Dec 29, 2016

A few XFAIL markers depend on other pull requests:

Some markers depend on unresolved libbson issues, some of which should be addressed in 1.6.0 (see also: CDRIVER-1947).

Lastly, this PR currently only implements the "valid" test cases. I still need to handle the "decodeErrors" tests.

@jmikola jmikola force-pushed the phpc-714 branch 2 times, most recently from e529d30 to 026ca5a Compare January 4, 2017 21:32
@jmikola
Copy link
Member Author

jmikola commented Jan 4, 2017

The "decodeErrors" and "parseErrors" tests are now handled by the conversion script and included in the PR, so I'm removing the WIP label.

@jmikola jmikola changed the title [WIP] PHPLIB-714: BSON corpus tests PHPLIB-714: BSON corpus tests Jan 4, 2017
@derickr derickr changed the title PHPLIB-714: BSON corpus tests PHPC-714: BSON corpus tests Jan 9, 2017
Copy link
Contributor

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but I didn't check all 870 tests...

@jmikola
Copy link
Member Author

jmikola commented Jan 10, 2017

Rebased with updated XFAIL blocks for other resolved tickets. We may want to hold off on merging this until libbson 1.6.0 is tagged (likely PHPC 1.3.0).

@jmikola jmikola changed the title PHPC-714: BSON corpus tests [WAIT] PHPC-714: BSON corpus tests Jan 10, 2017
@jmikola jmikola changed the title [WAIT] PHPC-714: BSON corpus tests PHPC-714: BSON corpus tests Jan 13, 2017
@jmikola
Copy link
Member Author

jmikola commented Jan 13, 2017

I moved the libbson 1.6.0 upgrade to its own PR (#511) and added XFAIL blocks to BSON corpus tests that still fail in 1.5.x. This will allow us to merge the corpus tests in our 1.2.x branch.

@jmikola jmikola merged commit 937a2c2 into mongodb:master Jan 13, 2017
jmikola added a commit that referenced this pull request Jan 13, 2017
@jmikola jmikola deleted the phpc-714 branch January 13, 2017 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants