-
Notifications
You must be signed in to change notification settings - Fork 209
PHPC-714: BSON corpus tests #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So is this still WIP? |
Changed it to WIP. I need to group the specific failures so we can relay those to the C driver team and then update the tests to XFAIL. |
f4b8922
to
838a305
Compare
661f810
to
b6dcdcd
Compare
A few XFAIL markers depend on other pull requests:
Some markers depend on unresolved libbson issues, some of which should be addressed in 1.6.0 (see also: CDRIVER-1947). Lastly, this PR currently only implements the "valid" test cases. I still need to handle the "decodeErrors" tests. |
e529d30
to
026ca5a
Compare
The "decodeErrors" and "parseErrors" tests are now handled by the conversion script and included in the PR, so I'm removing the WIP label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, but I didn't check all 870 tests...
Rebased with updated XFAIL blocks for other resolved tickets. We may want to hold off on merging this until libbson 1.6.0 is tagged (likely PHPC 1.3.0). |
I moved the libbson 1.6.0 upgrade to its own PR (#511) and added XFAIL blocks to BSON corpus tests that still fail in 1.5.x. This will allow us to merge the corpus tests in our 1.2.x branch. |
https://jira.mongodb.org/browse/PHPC-714
Also, various corpus test cases currently fail. This is likely due to libbson, so we may want to hold off until the C driver implements these tests. I expect that at least some issues cannot be resolved without breaking BC.