PYTHON-4558 Fix coverage and XML results for async tests #1738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
requested changes
Jul 16, 2024
| @@ -257,8 +254,7 @@ PIP_QUIET=0 python -m pip list | |||
| if [ -z "$GREEN_FRAMEWORK" ]; then | |||
| # Use --capture=tee-sys so pytest prints test output inline: | |||
| # https://docs.pytest.org/en/stable/how-to/capture-stdout-stderr.html | |||
| python -m pytest -v --capture=tee-sys --durations=5 --maxfail=10 $TEST_ARGS | |||
| python -m pytest -v --capture=tee-sys --durations=5 --maxfail=10 test/asynchronous/ $TEST_ARGS | |||
| python -m pytest -v --capture=tee-sys --durations=5 --maxfail=10 $TEST_SUITES $TEST_ARGS | |||
There was a problem hiding this comment.
Nice, this is a clean solution. Do we still need $TEST_ARGS?
There was a problem hiding this comment.
TEST_ARGS is still used to add --cov.
| shell: bash | ||
| run: | | ||
| cd sdist/test | ||
| ls | ||
| which python | ||
| pip install -e ".[test]" | ||
| pytest -v | ||
| pytest -v test/asynchronous/ | ||
| PYMONGO_MUST_CONNECT=1 pytest -v test/test_client_context.py |
There was a problem hiding this comment.
Has this test been just running the wrong suite this whole time?
There was a problem hiding this comment.
No but it just seems unnessecary to run the whole suite from the sdist, we already run the whole suite elsewhere on the same commit.
NoahStapp
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PYTHON-4558